-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4151: Reporting rooms #1938
base: main
Are you sure you want to change the base?
MSC4151: Reporting rooms #1938
Conversation
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@@ -5,9 +5,6 @@ Users may encounter content which they find inappropriate and should be | |||
able to report it to the server administrators or room moderators for | |||
review. This module defines a way for users to report content. | |||
|
|||
Content is reported based upon a negative score, where -100 is "most | |||
offensive" and 0 is "inoffensive". | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this here because it only applies to event reporting and is repeated in the corresponding endpoint's documentation.
properties: | ||
reason: | ||
type: string | ||
description: The reason the room is being reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content: | ||
application/json: | ||
schema: | ||
$ref: definitions/errors/rate_limited.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is technically correct since the MSC strongly recommends but doesn't require rate limiting.
@@ -29,7 +92,7 @@ paths: | |||
will require the homeserver to check whether a user is joined to | |||
the room. To combat this, homeserver implementations should add | |||
a random delay when generating a response. | |||
operationId: reportContent | |||
operationId: reportEvent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what consequences changing this has but the old ID felt unsuitable now that there are two endpoints in the module.
@@ -62,7 +125,7 @@ paths: | |||
and 0 is inoffensive. | |||
reason: | |||
type: string | |||
description: The reason the content is being reported. May be blank. | |||
description: The reason the content is being reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this as proposed in MSC2414 and thought it aligns well enough with the rest of this pull request to sneak in. 😇
As per matrix-org/matrix-spec-proposals#4151.
The MSC proposed that clients should hide reported rooms. However, there isn't any API for ignoring rooms yet. So I left that part out of the spec as otherwise clients would have to invent a system for doing this across devices.
Pull Request Checklist
Preview: https://pr1938--matrix-spec-previews.netlify.app